From ac3a51c624b945824064eae1da6e300ca676ce3d Mon Sep 17 00:00:00 2001 From: Peter Banik Date: Mon, 12 Aug 2024 11:48:15 +0200 Subject: [PATCH] Parse Binance API error response --- client/mm/libxc/binance.go | 33 ++++++++++++++++++++++++++++++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/client/mm/libxc/binance.go b/client/mm/libxc/binance.go index af41a9527f..85c67b796e 100644 --- a/client/mm/libxc/binance.go +++ b/client/mm/libxc/binance.go @@ -12,6 +12,7 @@ import ( "encoding/json" "errors" "fmt" + "io" "math" "net/http" "net/url" @@ -27,7 +28,6 @@ import ( "decred.org/dcrdex/client/mm/libxc/bntypes" "decred.org/dcrdex/dex" "decred.org/dcrdex/dex/calc" - "decred.org/dcrdex/dex/dexnet" "decred.org/dcrdex/dex/encode" "decred.org/dcrdex/dex/utils" ) @@ -1915,7 +1915,34 @@ func binanceMarketToDexMarkets(binanceBaseSymbol, binanceQuoteSymbol string, tok return markets } +type BNApiResponse struct { + Code int `json:"code"` + Msg string `json:"msg"` +} + func requestInto(req *http.Request, thing interface{}) error { - // bnc.log.Tracef("Sending request: %+v", req) - return dexnet.Do(req, thing, dexnet.WithSizeLimit(1<<24)) + var sizeLimit int64 = 1 << 24 + + resp, err := http.DefaultClient.Do(req) + if err != nil { + return fmt.Errorf("error performing request: %w", err) + } + defer resp.Body.Close() + // https://binance-docs.github.io/apidocs/websocket_api/en/#response-format + if resp.StatusCode != http.StatusOK { + var apiResp BNApiResponse + reader := io.LimitReader(resp.Body, sizeLimit) + if err = json.NewDecoder(reader).Decode(&apiResp); err != nil { + return fmt.Errorf("error decoding response: %w", err) + } + return fmt.Errorf("API error %d: %s (%d)", resp.StatusCode, apiResp.Msg, apiResp.Code) + } + if thing == nil { + return nil + } + reader := io.LimitReader(resp.Body, sizeLimit) + if err = json.NewDecoder(reader).Decode(thing); err != nil { + return fmt.Errorf("error decoding request: %w", err) + } + return nil }