Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"OUT" Node not useable anymore with Deconz 2.3.6 on Safari #217

Closed
EdStark666 opened this issue Oct 13, 2022 · 22 comments
Closed

"OUT" Node not useable anymore with Deconz 2.3.6 on Safari #217

EdStark666 opened this issue Oct 13, 2022 · 22 comments
Assignees
Labels
bug Something isn't working

Comments

@EdStark666
Copy link

Current Behavior

"OUT" Node has a bug which leads to the situation, that no commands can be set. Because of that, devices cant be controlled anymore with Deconz in Nodered.

Expected Behavior

Add commands in the OUT node like before.

Steps To Reproduce

Create OUT Node in Nodered and try to add homekit or state or config or custom command.

Example flow

paste your flow here

Environment

  • deCONZ plugin version: 2.3.6
  • HomeKit plugin version (if used):
  • Node-RED version: 3.0.2
  • Node.js version:
  • npm version:
  • Platform/OS: RaspberryPi3
  • Browser: Safari
@EdStark666
Copy link
Author

Seems to be a safari problem. Works on chrome browser as before.

@Zehir
Copy link
Member

Zehir commented Oct 13, 2022

What version of Safari are you using ?
Did you have errors in the console ?

@EdStark666
Copy link
Author

EdStark666 commented Oct 13, 2022

Safari 16.0 on macOS 12.6 Monterey (newest SW).
Screenshot of issue: https://im.ge/i/2sjsLz
Yes, there are errors, screenshot https://im.ge/i/2sjqTS

@Zehir
Copy link
Member

Zehir commented Oct 13, 2022

This can't help me, I will try to install safari on windows later

@Zehir Zehir changed the title "OUT" Node not useable anymore with Deconz 2.3.6 "OUT" Node not useable anymore with Deconz 2.3.6 on Safari Oct 13, 2022
@Zehir Zehir self-assigned this Oct 13, 2022
@Zehir Zehir added the bug Something isn't working label Oct 13, 2022
@Zehir
Copy link
Member

Zehir commented Oct 15, 2022

I tried on a new node using a safari from a virtual machine and I can't reproduce the issue. Could you come over discord to talk about that issue ? I ping you here.

@dionmes
Copy link

dionmes commented Nov 6, 2022

I got the same issue. The specifics option section and commands section do not expand or are populated under safari on MacOS. This is the first time I try this out, thought I did something wrong but then saw this thread.

Safari Version 16.1 (18614.2.9.1.12)

@fuzzy01
Copy link

fuzzy01 commented Dec 10, 2022

I have the same issue on MacOS. Very annoying.

Safari Version 16.1 (18614.2.9.1.12)
MacOS Ventura 13.0.1

@raddi
Copy link

raddi commented Dec 11, 2022

Same issue on macOS Ventura 13.0.1 and Safari 16.1 - The Commands tab seems to be empty, but in Chrome it does work, so there may are some display issues in safari?
Bildschirm­foto 2022-12-11 um 18 43 23

@Zehir
Copy link
Member

Zehir commented Dec 11, 2022

I have no idea why this don't work on safari and I can't reproduce on my side. Somebody can come on discord to debug this in real time ?

@Zehir
Copy link
Member

Zehir commented Dec 20, 2022

Does this happen on ipad too ?

@dionmes
Copy link

dionmes commented Dec 20, 2022

I can confirm this happens on iPad too and also in Chrome on the iPad (which makes sense).

@Zehir
Copy link
Member

Zehir commented Dec 21, 2022

For some reason doing this fix the issue :

  async generateTypedInput(container, options, stupidFix = "safari") {
    console.log("Stupid fix for " + stupidFix);

By adding an new param and doing something with it like print in the console it's fix.
The issue is that the options value became undefined but it defined when the method is called. I don't understand what is happening here.

I looking for a better fix

@Zehir Zehir closed this as completed in e8ccb7c Dec 21, 2022
@Zehir
Copy link
Member

Zehir commented Dec 21, 2022

Released in 2.3.7

@dionmes
Copy link

dionmes commented Dec 21, 2022

Sounds good, but in NR I can already upgrade to 2.3.8.

@Zehir
Copy link
Member

Zehir commented Dec 21, 2022

Sounds good, but in NR I can already upgrade to 2.3.8.

Yes à push an other update in between

@Automayted
Copy link

I'm seeing a very similar issue in macOS 12.6.1 with Safari 16.2 running v2.3.8.

Safari shows a mix of light and cover parameters, notably missing transition time:
Screen Shot 2022-12-27 at 11 05 08 PM

Chrome shows everything correctly:
Screen Shot 2022-12-27 at 11 05 15 PM

I've cleared all Safari cache, rebooted, all with no change.

Am I overlooking something obvious, or is there still an issue with Safari in v2.3.8?

@Zehir
Copy link
Member

Zehir commented Dec 28, 2022

Damned safari

@Zehir Zehir reopened this Dec 28, 2022
@Automayted
Copy link

Damned safari

Ha. Let me know if I can offer any assistance with logs or whatnot. Thanks for all your efforts on this project!

@Zehir
Copy link
Member

Zehir commented Dec 30, 2022

Damned safari

Ha. Let me know if I can offer any assistance with logs or whatnot. Thanks for all your efforts on this project!

Yes could you check on the browser console if there is any errors ?

@Automayted
Copy link

Damned safari

Ha. Let me know if I can offer any assistance with logs or whatnot. Thanks for all your efforts on this project!

Yes could you check on the browser console if there is any errors ?

I get this one each time I open a deCONZ OUT node:

[Error] Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'container.append') (anonymous function) (deconz-editor.js:1:41856) asyncFunctionResume (anonymous function) promiseReactionJobWithoutPromise promiseReactionJob

@Zehir
Copy link
Member

Zehir commented Dec 30, 2022

Ok I see it's the same safari bug where object became undefined by magic, I will work on a fix this weekend

@Zehir Zehir closed this as completed in 762397c Jan 4, 2023
@Zehir
Copy link
Member

Zehir commented Jan 4, 2023

Was related to mishoo/UglifyJS#5155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants