fix(#6355): publish button dropdown items overflow menu #6796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for decap-www canceled.
|
ghughes13
changed the title
martinjagodic
approved these changes
Jun 12, 2023
martinjagodic
pushed a commit
that referenced
this pull request
Oct 16, 2023
martinjagodic
pushed a commit
that referenced
this pull request
Oct 17, 2023
martinjagodic
pushed a commit
to geotrev/netlify-cms
that referenced
this pull request
Oct 17, 2023
…porg#6796) * fix: resolved text overflowing on publish button options * fix: adjusted where min-width was changed for publish drop down items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6355
Summary
Fixes issue where publish drop down items were overflowing and not visible by:
Increasing the dropdown menu width to 200px (Looks cramped and breaks into 3 lines at current width of 150px, but happy to undo this part if people disagree)
Adjusting publish dropdown menu min-width property so that text wraps properly.
Test plan
This issue occurred in French, English, and German (Although issue only complained about French, this fixes all 3). Since these are the only locals explicitly declared in the code (That I can find) those are all I tested, however this fix should work regardless of the length (see lorem ipsum screenshot examples)
Broken - English
Fixed - English
Fixed - French
Fixed - German
Fixed - Long Lorem Ipsum text to demo that longer text works
Fixed - Longer lorem ipsum text just in case anyone wants to see it
Image of text wrapping to 3 lines at 150px. Again, just seemed cramped like this so extended by 50px.
Checklist
Please add a
xinside each checkbox: