Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing MAX_SEN_LEN and EPOCH #9

Open
luckystar1992 opened this issue Dec 10, 2019 · 0 comments
Open

missing MAX_SEN_LEN and EPOCH #9

luckystar1992 opened this issue Dec 10, 2019 · 0 comments

Comments

@luckystar1992
Copy link

Compare to the original C code released by Google, MAX_SEN_LEN and EPOCH is missing, which caused these two problem.

[1] In the sub training process, each process read lines from file start and end. Once the input file contains only the one line (for example text8 corpus), following code snippets would caused bug.

 while fi.tell() < end:
        line = fi.readline().strip()
        # Skip blank lines
        if not line:
            continue

line = fi.readline().strip() would load the whole tokens from start.

[2] EPOCH would create embedding with more training samples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant