diff --git a/channeld/full_channel.c b/channeld/full_channel.c index 5818f229efc0..eb42cacf834f 100644 --- a/channeld/full_channel.c +++ b/channeld/full_channel.c @@ -1349,7 +1349,7 @@ bool channel_sending_commit(struct channel *channel, SENT_REMOVE_HTLC }; status_debug("Trying commit"); - // TODO: Should this method check for splices? + // DTODO: Should this method check for splices? /* A sending node: * - MUST NOT send a `commitment_signed` message that does not include any * updates, or add or remove splices. diff --git a/hsmd/libhsmd.c b/hsmd/libhsmd.c index 7cddc9e1e407..ab05b3203184 100644 --- a/hsmd/libhsmd.c +++ b/hsmd/libhsmd.c @@ -103,7 +103,7 @@ bool hsmd_check_client_capabilities(struct hsmd_client *client, return (client->capabilities & HSM_CAP_SIGN_CLOSING_TX) != 0; case WIRE_HSMD_SIGN_SPLICE_TX: - return true; //TODO: check capabilities + return true; //DTODO: check capabilities case WIRE_HSMD_SIGN_OPTION_WILL_FUND_OFFER: return (client->capabilities & HSM_CAP_SIGN_WILL_FUND_OFFER) != 0; @@ -1068,7 +1068,7 @@ static u8 *handle_sign_mutual_close_tx(struct hsmd_client *c, const u8 *msg_in) } /* This is used by channeld to sign the final splice tx. */ -//TODO: Merge this into the close_tx +//DTODO: Merge this into the close_tx static u8 *handle_sign_splice_tx(struct hsmd_client *c, const u8 *msg_in) { struct secret channel_seed; diff --git a/lightningd/Tasks.txt b/lightningd/Tasks.txt index eafa29899990..07acbc6234ab 100644 --- a/lightningd/Tasks.txt +++ b/lightningd/Tasks.txt @@ -14,7 +14,7 @@ DONE * Make commit_sigs work after splice confirms * validate point of no return when lightningd * At the last step before signing the splice, validate all the commit sigs etc thoroughly before. * -* Change all TODOs in my code to DTODOs +DONE * Change all TODOs in my code to DTODOs * Add helpful log messages in places to be able to see what's going on * Figure out why we can't pay invoices after splice_init * Change splice RPC to use channel_id instead of peer_id diff --git a/lightningd/dual_open_control.c b/lightningd/dual_open_control.c index fc239eba8f34..7c4e3b4c5fb5 100644 --- a/lightningd/dual_open_control.c +++ b/lightningd/dual_open_control.c @@ -2760,7 +2760,7 @@ static void handle_psbt_changed(struct subd *dualopend, abort(); } -// TODO: splitting into a one time event +// DTODO: splitting into a one time event // and multiple sig updates over time static void handle_commit_received(struct subd *dualopend, struct channel *channel, diff --git a/lightningd/peer_control.c b/lightningd/peer_control.c index 372033173025..fab1e61808f1 100644 --- a/lightningd/peer_control.c +++ b/lightningd/peer_control.c @@ -1293,7 +1293,7 @@ static enum watch_result funding_depth_cb(struct lightningd *ld, return DELETE_WATCH; } - // TODO: Handle the case where we get here with an inflight splice + // DTODO: Handle the case where we get here with an inflight splice // 1) Make the inflight *not* replace the existing tx until 6 confs // 2) Current code just sets the last_sig to 0x0. Need to set that to the right thing // 3) Make it go! @@ -1357,7 +1357,7 @@ static enum watch_result funding_depth_cb(struct lightningd *ld, else if (false && channel->state != CHANNELD_AWAITING_SPLICE && !short_channel_id_eq(channel->scid, &scid)) { - /* TODO: This is firing after 6 depth splice */ + /* DTODO: This is firing after 6 depth splice */ /* During reorgs: * This normally restarts channeld, initialized with updated scid diff --git a/openingd/dualopend.c b/openingd/dualopend.c index 6fb8eab66aa3..fb7cca0021cb 100644 --- a/openingd/dualopend.c +++ b/openingd/dualopend.c @@ -2501,7 +2501,7 @@ static u8 *opener_commits(struct state *state, } - // TODO: Copy the below procedure for splicing + // DTODO: Copy the below procedure for splicing // We probably need to do this in response to commitment_signed message // and / or in the revoke_and_ack code