mtip32xx: fix bad use of smp_processor_id()

axboe · axboe · commit 7f328908f9cb · 2014-03-10T14:32:47.000-06:00
mtip_pci_probe() dumps the current CPU when loaded, but it does
so in a preemptible context. Hence smp_processor_id() correctly
warns:

BUG: using smp_processor_id() in preemptible [00000000] code: systemd-udevd/155
caller is mtip_pci_probe+0x53/0x880 [mtip32xx]

Switch to raw_smp_processor_id(), since it's just informational
and persistent accuracy isn't important.

Signed-off-by: Jens Axboe &lt;axboe@fb.com&gt;
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
@@ -4498,7 +4498,7 @@ static int mtip_pci_probe(struct pci_dev *pdev,
 	}
 	dev_info(&pdev->dev, "NUMA node %d (closest: %d,%d, probe on %d:%d)\n",
 		my_node, pcibus_to_node(pdev->bus), dev_to_node(&pdev->dev),
-		cpu_to_node(smp_processor_id()), smp_processor_id());
+		cpu_to_node(raw_smp_processor_id()), raw_smp_processor_id());
 
 	dd = kzalloc_node(sizeof(struct driver_data), GFP_KERNEL, my_node);
 	if (dd == NULL) {

Original file line number	Diff line number	Diff line change
`@@ -4498,7 +4498,7 @@ static int mtip_pci_probe(struct pci_dev *pdev,`
`4498`	`4498`	`}`
`4499`	`4499`	`dev_info(&pdev->dev, "NUMA node %d (closest: %d,%d, probe on %d:%d)\n",`
`4500`	`4500`	`my_node, pcibus_to_node(pdev->bus), dev_to_node(&pdev->dev),`
`4501`		`- cpu_to_node(smp_processor_id()), smp_processor_id());`
	`4501`	`+ cpu_to_node(raw_smp_processor_id()), raw_smp_processor_id());`
`4502`	`4502`
`4503`	`4503`	`dd = kzalloc_node(sizeof(struct driver_data), GFP_KERNEL, my_node);`
`4504`	`4504`	`if (dd == NULL) {`