Deleting a snapshot might delete a different snapshot with the same prefix

[castanearie]

When one snapshot's name consists of another snapshot's name followed by a dash, it might be erroneously selected during cleanup. The following shell history shows how I create two snapshots, foo and foo-bar, and then try to delete foo, but foo-bar is deleted instead.

$ ddev snapshot -n foo
$ ddev snapshot -n foo-bar
$ ddev snapshot -l
┌──────────┬────────────┐
│ SNAPSHOT │ CREATED    │
├──────────┼────────────┤
│ foo-bar  │ 2024-11-06 │
├──────────┼────────────┤
│ foo      │ 2024-11-06 │
└──────────┴────────────┘
$ ddev snapshot -n foo -C
$ ddev snapshot -l
┌──────────┬────────────┐
│ SNAPSHOT │ CREATED    │
├──────────┼────────────┤
│ foo      │ 2024-11-06 │
└──────────┴────────────┘
$ ddev -v
ddev version v1.23.5

[rfay]

Thanks for the concise description. I'm able to reproduce this.

[rfay]

This is due to a flaw in the logic at

ddev/pkg/ddevapp/snapshot.go

Lines 309 to 313 in 4c5cdb6

	for _, file := range files {
	if strings.HasPrefix(file, name+"-") {
	return file, nil
	}
	}

It only happens with snapshots with a - in them, there's a bad assumption that - is an official delimiter.

Are you interested in trying a PR to fix this @castanearie? We'd help all the way. https://ddev.readthedocs.io/en/stable/developers/building-contributing/

[castanearie]

Never did anything in Go, but can certainly try! Will probably be able to put something together in the next couple days.