Skip to content

Commit 7150fd3

Browse files
committed
Use python -m pip install -U pip on Windows
Don't run `pip install --upgrade pip` on Windows, it started to fail in our Jenkins node and this is not the right command. https://jira.mesosphere.com/browse/DCOS_OSS-2332 https://pip.pypa.io/en/stable/installing/#upgrading-pip pypa/pip#1299
1 parent fe1fd6f commit 7150fd3

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

python/bin/env.sh

+5-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,11 @@ if [ ! -d "${BUILDDIR}/${VENV}" ]; then
4040

4141
# Install all requirements into the virtualenv.
4242
echo "Installing virtualenv requirements..."
43-
${BUILDDIR}/${VENV}/${BIN}/pip${EXE} install --upgrade pip
43+
if [ "$(uname)" = "Windows_NT" ]; then
44+
${PYTHON} -m pip install -U pip
45+
else
46+
${BUILDDIR}/${VENV}/${BIN}/pip${EXE} install --upgrade pip
47+
fi
4448
${BUILDDIR}/${VENV}/${BIN}/pip${EXE} install -r ${BASEDIR}/requirements.txt
4549
${BUILDDIR}/${VENV}/${BIN}/pip${EXE} install -e ${BASEDIR}
4650
if [ "$(uname)" = "Windows_NT" ]; then

0 commit comments

Comments
 (0)