Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Late annotations are being dropped #214

Open
matt-sheets opened this issue May 2, 2023 · 0 comments
Open

Late annotations are being dropped #214

matt-sheets opened this issue May 2, 2023 · 0 comments

Comments

@matt-sheets
Copy link
Collaborator

As seen in the following PR:
#192
We added the concept of early and late annotations. Processing the late annotations added a 6% increase in our benchmark times.

Currently we do not leverage any late annotations, so dropping them has no negative functionality impact at this time. Since we don't want to take the performance hit, we will continue with them being dropped for the time being.

We should try to resolve the performance issue before we start processing the late annotations if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant