Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context parsing should do its own error handling #171

Open
dburgener opened this issue Apr 13, 2023 · 0 comments
Open

Context parsing should do its own error handling #171

dburgener opened this issue Apr 13, 2023 · 0 comments

Comments

@dburgener
Copy link
Owner

Currently Context::try_from() (both the String and &str variants) return () on error and trust the level above to write a good error message. This discards information about what failed in parsing. try_from() should return something more helpful, and the level above can decide what it wants to do. Perhaps rather than a full error, try_from() might return just a help string. Or maybe just a normal CompileError works. More analysis should be done on callers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant