-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbt quoting does not work as expected #497
Comments
The double quotes work fine in MS SQL. Did you try running the query? It works fine with tables that start with numbers. I don't have servers named like that to try. |
I think this issue can be closed as 'by design'. Sql Server databases have Quoted Identifiers set to False by default but most drivers, including the Sql Server ODBC driver, set Quoted Identifiers are on by default, which is the ANSI standard. If OP is having issues with quoted identifiers it might be the driver he is using. Here is a good article describing Sql Server's quoted identifiers settings: Issue 2986 referenced by OP is simply cleaning up terminology that probably evolved during the organic development of the project. This assumes the DBT configuration has quoting set to true (default).
I tested this using the following database and tables:
And the following DBT model:
|
The quoting for msft sql not working. Dbt use double quotes when the config quoting is turned on but ms sql or tsql use square brackets.
I need quoting for databases and table. Our table or database prefix is sometimes a number like
101_Customers
.Example:
dbt config:
The dbt compilation result:
SELECT * FROM "101_supplier"."core"."supplier"
What I expected:
SELECT * FROM [101_supplier].[core].[supplier]
Question:
Is there a way to configure the quoting for database, schema and identifier with square brackets. Or this issue a topic for the dbt core team?
Additional context
I found a core issue with similar problems: link
The text was updated successfully, but these errors were encountered: