-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CSP policy #6629
Open
john-rock
wants to merge
9
commits into
current
Choose a base branch
from
update-strict-csp
base: current
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update CSP policy #6629
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
size: x-small
This change will take under 3 hours to fix.
label
Dec 9, 2024
JKarlavige
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! confirmed existing iframes are not affected: https://docs-getdbt-com-git-update-strict-csp-dbt-labs.vercel.app/blog/guide-to-jinja-debug
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
This PR updates the Content Security Policy headers, specifically
frame-ancestors
, in order to reduce the vulnerability of clickjacking attacks based on our most recent security report.Changes
Adds the following frame-ancestors into the content security policy
https://*.mutinyhq.com
- Allow experimentation previews within Mutiny dashboardhttps://*.getdbt.com
- Allows docs to be embedded on sites within our domainPreview
https://docs-getdbt-com-git-update-strict-csp-dbt-labs.vercel.app/
Testing