-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only allow squash commits and disallow merge commits and rebase merge #5635
Comments
Hey @dbeatty10 it appears this has been done. Was that you who made the change? I'm just checking with the front end team as we have other things going on and want to make sure this aligns across the board (with front end eng etc) |
One thing to consider is these disadvantages of merge & squashing:
|
Note that Jason K likes the idea of having more than one enabled. Though this could be different with an OS repo. Also I heavily use the commit history to pinpoint changes. @mirnawong1 @matthewshaver or @nghi-ly any thoughts? |
Oops! I ticked them just for the purpose of a screenshot, and I didn't realize that it saved it automatically! 😬 Sorry about that! Just now changed it back to what it was originally: |
@dbeatty10 and @runleonarun do we still need this issue? it seems like we have it squashed now right? |
@mirnawong1 I think we just need to talk about this as a team to discuss the tradeoffs. Though, it seems like the default behavior (Squash and merge) is what's mostly used. |
Problem
The commit history for some source code files is not easy to read due to:
It looks to me that these PRs were merged with a merge commit rather than a squash merge.
Here's an example:
https://github.com/dbt-labs/docs.getdbt.com/commits/current/website/docs/reference/global-configs/project-flags.md
Proposed solution
Other repos like
dbt-core
don't allow merge commits and only allow squash merges.To do the same in
docs.getdbt.com
, open the repo settings and change this:To this:
The text was updated successfully, but these errors were encountered: