You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our PR template is pretty long, which makes it onerous to use. It is also unnecessarily different from the PR templates of dbt-core, dbt-adapters, etc.
So we should replace these (6) checklist items:
I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
BigQuery
Postgres
Redshift
Snowflake
I have added tests & descriptions to my models (and macros if applicable)
With these (2) checklist items:
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
Any bug fixes and feature requests should have associated tests, and those tests should run against all the aforementioned data platforms.
Who will this benefit?
This will reduce the length of the PR checklist, which will make it easier to complete (in alignment with the suggestions within the Checklist Manifesto).
This will also more closely align the PR template within dbt-utils with the PR templates of dbt-core, dbt-adapters, etc.
The text was updated successfully, but these errors were encountered:
Describe the "under the hood" change
Our PR template is pretty long, which makes it onerous to use. It is also unnecessarily different from the PR templates of dbt-core, dbt-adapters, etc.
So we should replace these (6) checklist items:
With these (2) checklist items:
Any bug fixes and feature requests should have associated tests, and those tests should run against all the aforementioned data platforms.
Who will this benefit?
This will reduce the length of the PR checklist, which will make it easier to complete (in alignment with the suggestions within the Checklist Manifesto).
This will also more closely align the PR template within dbt-utils with the PR templates of dbt-core, dbt-adapters, etc.
The text was updated successfully, but these errors were encountered: