-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate why the BQ integration test didn't fail for quoted column name #540
Comments
(The format of this response is an experiment utilizing a subset of the MADR template.) Context and Problem StatementIs there a way to cause Considered Options
Pros and Cons of the Options
|
This is an awesome investigation into possible solutions here - thank you @dbeatty10!!! Feels like if we could get this working off of dbt build alone that would be a tremendous win. Two things to think through there on how we might mitigate the downside of it not working with
Those points aside, curious to hear which one you think would be best to move forward on. |
I'm interested in pursuing Rationale:
|
Beautiful - let's do it! |
Describe the bug
We caused #536 (fixed in #537) because of this change which was designed to avoid a similar issue in reverse from Snowflake (that it would have uppercased the column and failed to match in jinja, see #484.
Looking at the Circle logs for the job, it turns out that the table did error, but:
Steps to reproduce
dbt test
invocation (see here)Expected results
CI to fail, because something didn't work
Actual results
No error because dbt test (the final step) still succeeds
Screenshots and log output
Linked above, but in case Circle has thrown away the logs by the time we get to this: utils-bq-logs.txt
The text was updated successfully, but these errors were encountered: