-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbt_utils.star
macros bug
#506
Comments
@mc-introhive Thanks for expressing interest in contributing a fix - I think will be as simple as changing https://github.com/dbt-labs/dbt-utils/blob/main/macros/sql/star.sql#L11 to |
Haha, true, that seems quite straightforward ;) I will work on that PR, and get more into the weeds of how to contribute, build and test dbt-utils :) |
Oops, I don't have permission to push branches :) |
@mc-introhive you can contribute by forking the project and then opening a PR back to the main project. If you're new to open source, I recommend using the GitHub desktop app as it will guide you through the workflow of cloning a repo with the purpose of contributing back to it. For a change of this size, you could also fork it in the web browser, change the character in the web editor, and then open a PR from the prompt after that. Let me know if you need a bit more of a nudge in the right direction - happy to help get people set up to contribute! |
Yeah, I'm quite new to the open-source contribution process, and thank you for pointing me to the right direction! Is this what I'm supposed to do?
Am I on the right track? |
@mc-introhive Try this,
You may have to close your PR at mc-introhive#1 and then retry if what I suggested above doesn't work. |
Describe the bug
I created an issue in
sqlfluff
repo, becausesqlfluff
refuses to recognizedbt_utils
macros. More details (steps to reproduce, expected results, actual restuls, logs, system info, etc.) can be found in sqlfluff#2712. However, it turns out when runsqlfluff lint -v
, when it hitsdbt_utils.star
, specifically this block https://github.com/dbt-labs/dbt-utils/blob/main/macros/sql/star.sql#L11 it failed to recognize theexecute
flag. But it should've been recognized becausesqlfluff
does compile dbt projects which will trigger anexecute
flag to be true.Which database are you using dbt with?
Are you interested in contributing the fix?
Yup :)
The text was updated successfully, but these errors were encountered: