Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when a dbt project contains tests: instead of data_tests: #489

Closed
dbeatty10 opened this issue Sep 5, 2024 · 1 comment
Closed

Warn when a dbt project contains tests: instead of data_tests: #489

dbeatty10 opened this issue Sep 5, 2024 · 1 comment
Labels
enhancement New feature or request triage

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Sep 5, 2024

Describe the feature

Raise a warning whenever the tests: config is used instead of data_tests: (in order to disambiguate from unit_tests:).

This scenario is going to be removed as a deprecation warning in dbt-core when dbt-labs/dbt-core#10564 is resolved.

But data_tests: is the recommended best practice (even if tests: is supported indefinitely by dbt-core).

Describe alternatives you've considered

  1. Keeping it as as deprecation warning in dbt-core.
  2. Converting to just an info level or debug level message in the dbt-core logs.
  3. Create some new dbt package that handles things like this, #477, etc.

Additional context

data_tests: was added in v1.8, so any versions of dbt-core earlier than that can't use it.

This is similar in spirit to #477.

Who will this benefit?

Users that want to be aware of best practices that aren't official warnings in dbt-core.

@dave-connors-3
Copy link
Collaborator

given that we are removing this warning and do not plan to remove back compatibility, we are going to close this for now!

@dbeatty10 dbeatty10 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

No branches or pull requests

2 participants