Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump babel and webpack dependencies as of June 2024 #513

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented Jun 12, 2024

Description

We have several alerts from Dependabot because we haven't bumped package versions in a while: https://github.com/dbt-labs/dbt-docs/network/dependencies.

This PR aims to tackle outdated dependencies of babel, html-webpack-plugin and svg-url-loader.

html-webpack-inline-source-plugin was also EOL, so I replaced it with the very similar html-inline-script-webpack-plugin as per guidance from the README.

Checklist

@cla-bot cla-bot bot added the cla:yes label Jun 12, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@aranke
Copy link
Member Author

aranke commented Jun 13, 2024

🎩 locally with internal-analytics artifacts was successful

SCR-20240613-naaf
SCR-20240613-narl
SCR-20240613-naen SCR-20240613-nahg

@aranke aranke marked this pull request as ready for review June 13, 2024 14:11
@@ -5,15 +5,17 @@
"start": "npx webpack serve"
},
"devDependencies": {
"@babel/core": "^7.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@aranke aranke merged commit 74a1d28 into main Jun 13, 2024
11 checks passed
@aranke aranke deleted the fix_npm_vulns_jun_24 branch June 13, 2024 14:22
@MichelleArk MichelleArk changed the title Fix npm security vulnerabilities as of June 2024 Bump babel and webpack dependencies as of June 2024 Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants