Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fully remove support - we should not support spaces in model names #9834

Closed
1 task done
graciegoheen opened this issue Mar 29, 2024 · 1 comment
Closed
1 task done
Labels

Comments

@graciegoheen
Copy link
Contributor

graciegoheen commented Mar 29, 2024

Created as a follow up to #9397

Housekeeping

  • I am a maintainer of dbt-core

Short description

In 1.8 we began emitting warnings about spaces in model names. In 1.9 we should instead be raising an error. The work done for this for 1.8 (#9886) included a project flag allow_spaces_in_model_names which was defaulted to True. To begin raising errors, this needs to be defaulted to False instead.

Acceptance criteria

  • spaces in model names raise errors
    • this is disable-able

Suggested Tests

  • default behavior is to raise errors

Impact to Other Teams

N/A

Will backports be required?

N/A

Context

No response

@graciegoheen
Copy link
Contributor Author

Dupe of #9633

@graciegoheen graciegoheen closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2024
@graciegoheen graciegoheen removed this from the v1.9 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants