Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nest Metric node meta under config #9441

Closed
1 task done
Tracked by #9116
QMalcolm opened this issue Jan 24, 2024 · 0 comments · Fixed by #9580
Closed
1 task done
Tracked by #9116

Nest Metric node meta under config #9441

QMalcolm opened this issue Jan 24, 2024 · 0 comments · Fixed by #9580
Assignees
Labels
Impact: CA Impact: SL user docs [docs.getdbt.com] Needs better documentation
Milestone

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Jan 24, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

The old/deprecated way of having meta was putting it directly on a node. However, awhile back we deprecated that paradigm and moved to nesting meta under a node's config. When revamped Metric nodes in 1.6, we forgot to move to the new meta paradigm, and thus Metric nodes have only been supporting the deprecated path. We need to ensure we support the desired path.

Acceptance criteria

  • Metric nodes have a meta property under their config property
  • During parsing, flat meta specifications should end up under the config.meta

Suggested Tests

  • Metric meta can be specified in the dbt_project.yaml config specification
  • In metric yaml, people can specify meta directly on a metric or under a metric's config, both should end up in a metrics config.meta

Impact to Other Teams

Change impacts Semantic Layer team (as they requested this).
Change impacts Artifacts team (change to the artifacts)

Will backports be required?

No

Context

No response

@QMalcolm QMalcolm added user docs [docs.getdbt.com] Needs better documentation Impact: CA Impact: SL labels Jan 24, 2024
@QMalcolm QMalcolm changed the title Nest Metric node meta under `configs Nest Metric node meta under configs Jan 24, 2024
@QMalcolm QMalcolm changed the title Nest Metric node meta under configs Nest Metric node meta under config Jan 24, 2024
@martynydbt martynydbt added this to the v1.8 milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact: CA Impact: SL user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants