Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3546] Remove restrictive pathspec version depencency (upper bound) #9372

Closed
2 tasks done
rzjfr opened this issue Jan 13, 2024 · 1 comment · Fixed by #9373
Closed
2 tasks done

[CT-3546] Remove restrictive pathspec version depencency (upper bound) #9372

rzjfr opened this issue Jan 13, 2024 · 1 comment · Fixed by #9373
Labels
dependencies Changes to the version of dbt dependencies

Comments

@rzjfr
Copy link
Contributor

rzjfr commented Jan 13, 2024

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Currently pathspec>=0.9,<0.12 which conflicts with latest version of pathspec (0.12.1). I can't find any reason specifically for <0.12. It seems to be consequence of dependebot upgrading more restrictive pathspec~=0.9 here and then later here

Expected Behavior

I can't find any reason to restrict pathspec <0.12. I couldn't find any major change that can break anything related to this package in pathspec change log.

Steps To Reproduce

  1. pip install dbt-core==1.7.4 -c <(echo "pathspec==0.12.1")

Relevant log output

The conflict is caused by:
    dbt-core 1.7.4 depends on pathspec<0.12 and >=0.9
    The user requested (constraint) pathspec==0.12.1

Environment

- OS: NA
- Python: >3.8
- dbt: >1.2.6

Which database adapter are you using with dbt?

No response

Additional Context

No response

@rzjfr rzjfr added bug Something isn't working triage labels Jan 13, 2024
@github-actions github-actions bot changed the title [Bug] too restrictive pathspec version depencency (upper bound) [CT-3546] [Bug] too restrictive pathspec version depencency (upper bound) Jan 13, 2024
@dbeatty10 dbeatty10 added enhancement New feature or request dependencies Changes to the version of dbt dependencies and removed bug Something isn't working triage labels Jan 16, 2024
@dbeatty10 dbeatty10 changed the title [CT-3546] [Bug] too restrictive pathspec version depencency (upper bound) [CT-3546] Remove restrictive pathspec version depencency (upper bound) Jan 16, 2024
@dbeatty10 dbeatty10 removed the enhancement New feature or request label Jan 16, 2024
@WillAyd
Copy link

WillAyd commented Mar 6, 2024

Looking forward to the fix. Airflow 2.8 pins pathspec to 0.12.1 so it is impossible to use the current 1.7.x series there without violating constraints

https://raw.githubusercontent.com/apache/airflow/constraints-2.8.1/constraints-3.11.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes to the version of dbt dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants