Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3538] [Adapter Decoupling] Add dbt-common as dependency and remove dbt/common subdir #9357

Closed
1 task done
Tracked by #4
MichelleArk opened this issue Jan 10, 2024 · 0 comments · Fixed by #9342 or #9368
Closed
1 task done
Tracked by #4
Assignees

Comments

@MichelleArk
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

As part of the effort to decouple dbt/adapters from core, we have created a new top-level directory that contains utilities used by both dbt-adapter and dbt-core. The code from dbt/common can be removed once https://github.com/dbt-labs/dbt-common is set up to contain it. The code from dbt/common can be removed once https://github.com/dbt-labs/dbt-common is set up to contain it, and can be replaced by a new dependency in setup.py

Acceptance criteria

  • Delete dbt/common
  • Delete tests/unit/common
  • Add dbt-common to setup.py (as a GH dependency until release process for dbt-common is ironed out)
  • Remove any dependencies / third party stubs that are no longer necessary once dbt/common is moved out

Suggested Tests

N/A - tests moving to dbt/common as part of the refactor

Impact to Other Teams

Adapter implementations will no longer be able to import dbt.common directly from dbt-core as a result of this change, meaning 1P adapters will need to point to dbt-common as well as part of their migration plan. This is already accounted for in 1P Adapter Migrations in #8917.

Will backports be required?

No

Context

No response

@MichelleArk MichelleArk added the user docs [docs.getdbt.com] Needs better documentation label Jan 10, 2024
@github-actions github-actions bot changed the title [Adapter Decoupling] Add dbt-common as dependency and remove dbt/common subdir [CT-3538] [Adapter Decoupling] Add dbt-common as dependency and remove dbt/common subdir Jan 10, 2024
@MichelleArk MichelleArk added Impact: Adapters and removed user docs [docs.getdbt.com] Needs better documentation labels Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants