Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate TestCatalogRelationTypes to the shared adapter tests framework #8952

Merged
merged 7 commits into from
Nov 9, 2023

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Oct 31, 2023

Problem

The TestCatalogRelationTypes tests that were created for the dbt-maintained adapters are all very similar. This could be simplified to use shared code which can be configured by the adapter maintainer for their specific adapter. This makes adapter maintainers' jobs easier and aligns with our test inheritance pattern.

Solution

  • Move the body of TestCatalogRelationTypes into the shared adapter tests
  • Inherit this test back into dbt-postgres
  • Provide some in-line documentation of how to configure this test for adapter maintainers

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@mikealfare mikealfare self-assigned this Oct 31, 2023
@mikealfare mikealfare requested review from a team as code owners October 31, 2023 19:15
@cla-bot cla-bot bot added the cla:yes label Oct 31, 2023
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7fddd6e) 86.50% compared to head (30d4d62) 86.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8952      +/-   ##
==========================================
- Coverage   86.50%   86.44%   -0.07%     
==========================================
  Files         179      179              
  Lines       26508    26508              
==========================================
- Hits        22932    22916      -16     
- Misses       3576     3592      +16     
Flag Coverage Δ
integration 83.27% <ø> (-0.14%) ⬇️
unit 64.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	tests/functional/catalog_tests/test_relation_types.py
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@mikealfare mikealfare changed the title Alternative to #8945 Migrate TestCatalogRelationTypes to the shared adapter tests framework Nov 4, 2023
@mikealfare mikealfare merged commit b58e8e3 into main Nov 9, 2023
49 checks passed
@mikealfare mikealfare deleted the materialized-views/bug/adap-974-alternative branch November 9, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants