-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate TestCatalogRelationTypes to the shared adapter tests framework #8952
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8952 +/- ##
==========================================
- Coverage 86.50% 86.44% -0.07%
==========================================
Files 179 179
Lines 26508 26508
==========================================
- Hits 22932 22916 -16
- Misses 3576 3592 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # tests/functional/catalog_tests/test_relation_types.py
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Problem
The
TestCatalogRelationTypes
tests that were created for the dbt-maintained adapters are all very similar. This could be simplified to use shared code which can be configured by the adapter maintainer for their specific adapter. This makes adapter maintainers' jobs easier and aligns with our test inheritance pattern.Solution
TestCatalogRelationTypes
into the shared adapter testsdbt-postgres
Checklist