Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-2671] Check Semantic Interface Protocol Implementations in Core #7827

Closed
Tracked by #7498
peterallenwebb opened this issue Jun 8, 2023 · 0 comments · Fixed by #7848
Closed
Tracked by #7498

[CT-2671] Check Semantic Interface Protocol Implementations in Core #7827

peterallenwebb opened this issue Jun 8, 2023 · 0 comments · Fixed by #7848
Assignees
@QMalcolm
Labels
MetricFlow

Comments

@peterallenwebb
Copy link
Contributor

peterallenwebb commented Jun 8, 2023 •
edited
Loading

We recently overhauled the Metric and SemanticModel objects in Core, and they are now intended to be concrete implementations of interfaces defined as protocols in dbt-semantic-interfaces. We need to put in place a mechanism to automatically verify that these objects (and their child objects) do in fact implement their respective protocols.
@github-actions github-actions bot changed the title Check Semantic Interface Protocol Implementations in Core [CT-2671] Check Semantic Interface Protocol Implementations in Core Jun 8, 2023
This was referenced Jun 8, 2023
Closed
Merged
@emmyoop emmyoop mentioned this issue Jun 12, 2023
Closed
@QMalcolm QMalcolm mentioned this issue Jun 13, 2023
Merged
6 tasks
@QMalcolm QMalcolm linked a pull request Jun 13, 2023 that will close this issue
Update SemanticModel node to match DSI 0.1.0dev3 protocols #7848
Merged
6 tasks
@QMalcolm QMalcolm self-assigned this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QMalcolm QMalcolm

Labels
MetricFlow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update SemanticModel node to match DSI 0.1.0dev3 protocols dbt-labs/dbt-core
2 participants
@peterallenwebb @QMalcolm