Adapter quoting should use self.Relation.quote_character

[beckjake]

Describe the feature

Currently adapters each have to implement a quote method that returns a quoted form of the given identifier. But adapter plugins already define a Relation class that has a quote_character, which is associated with the adapter. The base adapter should implement a default quote that just does ''.join([self.Relation.quote_character, value, self.Relation.quote_character]) or similar.

Describe alternatives you've considered

Adapters can effectively define quote characters twice.

Additional context

All databases,sort of

Who will this benefit?

Plugin developers

[jtcohen6]

Adapters also have to implement their quote character again for columns by overriding the quoted method on the Column class. Ideally, we'd have a single place for an adapter to define its quote character, which is then reused across Relation.quote_character, Column.quoted, and adapter.quote().

[github-actions]

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.