-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add saved query resource type #10168
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10168 +/- ##
==========================================
- Coverage 88.62% 85.95% -2.68%
==========================================
Files 180 180
Lines 22422 22424 +2
==========================================
- Hits 19872 19275 -597
- Misses 2550 3149 +599
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This artifact check fail is expected, @emmyoop any idea how can we skip this? |
Schema difference
|
We should have bumped to v13 of the schema after 1.8.0 went out. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-10168-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6813007e2856d40a705f9929aa19c764802b1285
# Push it to GitHub
git push --set-upstream origin backport-10168-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latest Then, create a pull request where the |
* add saved query resource type * nits (cherry picked from commit 6813007)
resolves dbt-labs/dbt-docs#486
Problem
Resource Type did not exist on saved_query node
Solution
added the attribute
Checklist