Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit dbt-common/dbt-core cross dependencies #14

Closed
Tracked by #4
colin-rogers-dbt opened this issue Jan 4, 2024 · 4 comments
Closed
Tracked by #4

Audit dbt-common/dbt-core cross dependencies #14

colin-rogers-dbt opened this issue Jan 4, 2024 · 4 comments
Assignees
Milestone

Comments

@colin-rogers-dbt
Copy link
Collaborator

colin-rogers-dbt commented Jan 4, 2024

Description

We need to review dependencies between dbt-core and dbt-common and clean them up. Let's:

  • Settle on what versions of shared dependencies we use
  • Remove duplicate specification of dependencies from common/core
  • Update developer docs in dbt-common and dbt-core
    • non v1 deps (ie. colorama) have documentation around why they're non-v1 and we use them and how they're pinned
    • link back to dbt-common docs where appropriate to avoid doc duplication

Acceptance Criteria

  • duplicate dependencies are consolidated between dbt-core and dbt-common
  • Final audit of dependencies is complete and we have finished consolidation/removal of duplicate or unnecessary dependencies.

Impact to Other Teams

None

Context

@MichelleArk and @emmyoop have already done some work on this ticket and should be consulted as needed.

@graciegoheen
Copy link

@colin-rogers-dbt Is this for dbt-common or dbt-adapters?

@martynydbt martynydbt changed the title Audit cross adapter/core dependencies Audit cross common/core dependencies Jan 16, 2024
@emmyoop emmyoop changed the title Audit cross common/core dependencies Audit dbt-common/dbt-core cross dependencies Jan 16, 2024
@colin-rogers-dbt
Copy link
Collaborator Author

@graciegoheen this is for dbt-common

@aranke
Copy link
Member

aranke commented Mar 7, 2024

@MichelleArk @emmyoop Given that we don't want to merge dbt-labs/dbt-core#9725, what other work is required to mark this issue as done?

From my perspective, it looks like the A/C is already satisfied.

@MichelleArk
Copy link
Collaborator

@aranke - Would it be worth documenting the explicitly shared dependencies (in dbt-core setup.py, similar to this) so we don't accidentally remove/bump them independently going forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants