Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Test for date_spine should remove adapter-specific logic #209

Open
7 tasks
dbeatty10 opened this issue May 14, 2024 · 0 comments
Open
7 tasks
Labels
enhancement New feature or request

Comments

@dbeatty10
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-adapters

Short description

The test for the cross-adapter date_spine macro within fixture_date_spine.py contains adapter-specific logic like {% if target.type == 'postgres' %} that should be in dbt-postgres instead.

Context

History: this test was migrated effectively as-is from dbt-utils to dbt-core to dbt-adapters. But now we'll probably want to clean it up a bit.

Acceptance criteria

Tasks

Testing

Tasks

Security

No security concerns.

Docs

No doc updates needed.

Consequences

This change impacts any adapter that imports this test.

Depending on the final implementation in dbt-adapters, the adapter types that are currently hard-coded (postgres, bigquery, redshift) may need to provide overrides of the text fixtures as a result of this change.

@dbeatty10 dbeatty10 added the enhancement New feature or request label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant