-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce TableLastModifiedMetadataBatch and implement BaseAdapter.calculate_freshness_from_metadata_batch #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
MichelleArk
force-pushed
the
batch-metadata-freshness
branch
from
March 11, 2024 18:25
9f8da16
to
c541ca2
Compare
MichelleArk
force-pushed
the
batch-metadata-freshness
branch
from
March 11, 2024 20:35
c541ca2
to
727093c
Compare
…shness_from_metadata_batch
MichelleArk
force-pushed
the
batch-metadata-freshness
branch
from
March 25, 2024 20:57
b4cdd48
to
ed81529
Compare
MichelleArk
commented
Mar 25, 2024
MichelleArk
changed the title
[wip] Batch metadata freshness
Introduce TableLastModifiedMetadataBatch and implement BaseAdapter.calculate_freshness_from_metadata_batch
Mar 25, 2024
Merged
5 tasks
mikealfare
reviewed
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments/questions, some might even be useful.
3 tasks
3 tasks
This was referenced Apr 5, 2024
colin-rogers-dbt
approved these changes
Apr 11, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #138
docs dbt-labs/docs.getdbt.com/#
Problem
No base abstraction / implementation exists for calculating metadata-based freshness in batch
Solution
TableLastModifiedMetadataBatch
capability, for adapter implementations to indicate whether a batch version of metadata-based freshness calculation is available2.Implement
BaseAdapter.calculate_freshness_from_metadata_batch
calculate_freshness_from_metadata
but the interfaces were different enough that it would have been difficult to do in a backward-compatible way. However,calculate_freshness_from_metadata
was rewritten in terms ofcalculate_freshness_from_metadata_batch
so there are some wins in terms of code reuse here.needs_conn
toBaseAdapter.execute_macro
for callers to signal whether a macro will require an open connection or not. By default, this is false (preserving existing behaviour), butcalculate_freshness_from_metadata_batch
sets it to true.Checklist