Skip to content

Commit b3ded64

Browse files
authored
Merge pull request #1047 from miketheman/miketheman/fix-contrib
misc: update contributing guidelines
2 parents d1b36cc + 2f7883d commit b3ded64

File tree

3 files changed

+18
-5
lines changed

3 files changed

+18
-5
lines changed

CONTRIBUTING.rst

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,13 @@ Feature requests/proposals
1919
#. Provide as detailed description as possible
2020
* Use case is great to have
2121
#. There'll be a bit of discussion for the feature. Don't worry, if it is to be accepted, we'd like to support it, so we need to understand it thoroughly.
22-
22+
23+
Development
24+
-----------
25+
26+
#. Fork the repository
27+
#. Clone the repository
28+
#. Create a virtual environment with ``pipenv install --dev``
2329

2430
Pull requests
2531
-------------
@@ -46,7 +52,11 @@ Coding style
4652
Testing
4753
-------
4854

49-
# Tests are written using pytest.
50-
# PR tests run on Github Actions.
51-
# In order to run the tests locally you need to have one version of postgres installed. And pass envvar named `POSTGRES` with used version number
52-
# If you encounter any test failures due to locale issues, make sure that both `en_US.UTF-8` and `de_DE.UTF-8` are enabled in `/etc/locale.gen` and then run `sudo locale-gen`.
55+
#. Tests are written using `pytest <https://docs.pytest.org/>`_
56+
#. PR tests run on Github Actions.
57+
#. Run a PostgreSQL server [#]_, and create a default super user ``createuser --superuser postgres``
58+
#. Set envvar named ``POSTGRES`` with used version number
59+
#. Run tests with ``pipenv run pytest``
60+
#. If you encounter any test failures due to locale issues, make sure that both ``en_US.UTF-8`` and ``de_DE.UTF-8`` are enabled in ``/etc/locale.gen`` and then run ``sudo locale-gen``.
61+
62+
.. [#] Installing and configuring a PostgreSQL server is out of scope of this document. Please refer to `PostgreSQL documentation <https://www.postgresql.org/docs/>`_ for more information.

Pipfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ psycopg = "==3.2.3"
1111

1212
[dev-packages]
1313
towncrier = "==24.8.0"
14+
psycopg-binary = "==3.2.3"
1415
pytest-cov = "==6.0.0"
1516
pytest-xdist = "==3.6.1"
1617
mock = "==5.1.0"

newsfragments/1047.misc.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Update contributing guidelines.
2+
Simplify development installation with `psycopg-binary`.

0 commit comments

Comments
 (0)