New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with cheerio 0.19.0 #82

Closed

jbilcke opened this issue May 12, 2016 · 1 comment

Contributor

jbilcke commented May 12, 2016 •

edited

Loading

Hi,

There is an issue when parsing markdown: content gets translated to HTML,
but Cheerio then fails to parse it:

  ...
  text = "<textractwrapper>" + text + "<textractwrapper>";
  try {
    $ = cheerio.load( text );
    $('script').remove(); // <<< this line crashes with message:   TypeError: Cannot read property 'children' of undefined
  ...

This is caused by a regression in cheerio 0.19.0:

cheeriojs/cheerio#804

I would advise to upgrade to cheerio 0.20.0, which works fine

Owner

dbashford commented May 18, 2016

Closed by PR

dbashford closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment