Nil check #3
Merged
Nil check #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| # Unsafe version. Results in a segmentation fault if passed nils! | ||
| attach_function :ffi_distance, :levenshtein, [:string, :string], :int |
There was a problem hiding this comment.
FYI, If you want to make this private, you can do: private :ffi_distance after the declaration. Let me know if you want to do this before I merge! Thanks!
|
@dbalatero @harbu Is there anyway we can get this merged? |
|
hey! thanks for the nudge - i'll try to get to it tonight. |
|
merged, releasing a 1.0.3 gem shortly. |
|
1.0.3 is out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the "segmentation fault on nil arguments" issue by adding a check that the given arguments are really strings. If given something else will raise a TypeError. I also updated RSpec to version 2.