Skip to content

Conversation

@sarahbrng
Copy link
Contributor

@sarahbrng sarahbrng commented Nov 7, 2025

Proposed changes

add DBBreadcrumb component with documentation and examples

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/1309-umsetzung-der-komponente-im-code-anhand-konzept-design-für-alle-frameworks

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025

⚠️ No Changeset found

Latest commit: 03427d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sarahbrng sarahbrng self-assigned this Nov 7, 2025
@github-actions github-actions bot added 📕documentation Improvements or additions to documentation 📺showcases Changes to 1-n showcases 🏘components labels Nov 7, 2025
@mfranzke mfranzke changed the title 1309 umsetzung der komponente im code anhand konzept design für alle frameworks feat: add breadcrumb component Nov 7, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke mfranzke marked this pull request as draft November 7, 2025 19:27
size: 'small',
separator: 'chevron',
maxItems: undefined,
collapsedMenu: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The collapsedMenu prop is part of the props, but it is never used in the implementation.
We should either implement this behaviour as part of this story or drop the property for now to avoid exposing misleading props.

<button
type="button"
class="db-breadcrumb-ellipsis"
aria-label={props.ellipsisAriaLabel}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no property ellipsisAriaLabel is set, the button doesn't have an aria-label. We should use a default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏘components 📕documentation Improvements or additions to documentation 📺showcases Changes to 1-n showcases

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

4 participants