-
Notifications
You must be signed in to change notification settings - Fork 13
feat: add breadcrumb component #5424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add breadcrumb component #5424
The head ref may contain hidden characters: "1309-umsetzung-der-komponente-im-code-anhand-konzept-design-f\u00FCr-alle-frameworks"
Conversation
…Angular, React, and Vue
…ort across all showcases
…hevron and slash styles
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…-konzept-design-für-alle-frameworks
| size: 'small', | ||
| separator: 'chevron', | ||
| maxItems: undefined, | ||
| collapsedMenu: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The collapsedMenu prop is part of the props, but it is never used in the implementation.
We should either implement this behaviour as part of this story or drop the property for now to avoid exposing misleading props.
packages/components/src/components/breadcrumb/breadcrumb.lite.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/breadcrumb/breadcrumb.lite.tsx
Outdated
Show resolved
Hide resolved
| <button | ||
| type="button" | ||
| class="db-breadcrumb-ellipsis" | ||
| aria-label={props.ellipsisAriaLabel} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If no property ellipsisAriaLabel is set, the button doesn't have an aria-label. We should use a default value.
packages/components/src/components/breadcrumb/breadcrumb.lite.tsx
Outdated
Show resolved
Hide resolved
… mitosis-problems with helper
…al development" This reverts commit e73fbe1.
Proposed changes
add DBBreadcrumb component with documentation and examples
Types of changes
Further comments
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/1309-umsetzung-der-komponente-im-code-anhand-konzept-design-für-alle-frameworks