refactor: font generation to use execFile for security #4616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced usage of exec with execFile to prevent shell injection risks when running pyftsubset.
Contributor
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/alert-fix-8 |
mfranzke
added
🍒 cherryPick
nmerget
approved these changes
Jul 24, 2025
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in UX Engineering Team Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Replaced usage of exec with execFile to prevent shell injection risks when running pyftsubset. Arguments are now passed as arrays, and file paths are validated to avoid path traversal attacks. Improves security and reliability of font generation script.
Types of changes
Further comments