Skip to content

Conversation

@michaelmkraus
Copy link
Contributor

Proposed changes

  • fix(checkbox): adjust required asterisk spacing to bring it directly to the label
    Use negative margin on the ::after to offset the flex gap, bringing the asterisk directly next to the label without affecting
    the gap between the checkbox icon and the label.
  • also fixes this issue for radio and switch

closes #3038

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@github-actions
Copy link
Contributor

@nmerget
Copy link
Collaborator

nmerget commented May 28, 2025

@michaelmkraus this would not work for textarea, input and select

Maybe you can change the label stylings for switch and checkbox, by removing the gap: var(--db-spacing-fixed-xs); and add label > input {margin-inline-end: db-spacing-fixed-xs}

nmerget
nmerget previously approved these changes Jun 5, 2025
mfranzke and others added 2 commits June 6, 2025 08:35
# Conflicts:
#	__snapshots__/textarea/showcase/mobile-chrome/DBTextarea-should-match-screenshot-1/DBTextarea-should-match-screenshot.png
@michaelmkraus michaelmkraus merged commit a6a993b into main Jun 11, 2025
73 checks passed
@michaelmkraus michaelmkraus deleted the fix-checkbox-required-gap-to-asteriks branch June 11, 2025 12:22
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in UX Engineering Team Backlog Jun 11, 2025
@mfranzke mfranzke self-assigned this Jun 11, 2025
@mfranzke mfranzke added the 🐛bug Something isn't working label Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Checkbox required has gap between *

4 participants