Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more robust clang-format executable #19

Open
cacharle opened this issue Jan 9, 2022 · 2 comments
Open

Add more robust clang-format executable #19

cacharle opened this issue Jan 9, 2022 · 2 comments

Comments

@cacharle
Copy link
Collaborator

cacharle commented Jan 9, 2022

Right now, we're using a clang-format executable for both Linux and Mac to have the same version of clang-format no matter what version of it is installed on the user's system.

But this is causing issues with dynamic linking since different version can link to different .so.

#17 (comment)

We should find a way to either build a standalone clang-format executable or include the needed shared libaries with the c_formatter_42 package.

@cacharle
Copy link
Collaborator Author

cacharle commented Jan 9, 2022

@cacharle
Copy link
Collaborator Author

Dynamic linking stuff can be avoided if we have an executable by OS and architecture (only supports x86_64 right now

@cacharle cacharle reopened this Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant