Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Battle Tactics when values uniform across factions #1587

Merged
merged 13 commits into from
Jan 24, 2023

Conversation

davefatkin
Copy link
Contributor

I noticed when creating a Sylvaneth army with the app that if I included the Gallet Realm of Battle that the Battle Tactics for the GHB and Sylvaneth were in two different sections. 'Start Of Hero Phase` and 'Start Of Round', respectively.

I updated a couple of factions to use START_OF_HERO_PHASE rather than START_OF_ROUND to keep things in line with the existing pattern.

A few other things I changed to try and match existing patterns:

  • Removed Battle Tactic: from the name fields (I left them intact in realmscapes.ts)
  • Nurgle seemed to have it's own Battle Tactics schema that I changed to match existing patterns
  • Changed a handful of Battle Tactics that can only be played during certain turns to follow the pattern set by the Beasts of Chaos Battle Tactic for 'Fury of the Wild' (this one I wasn't sure if I should do or not, I felt it made things more explicit but it might end up making the rules output too verbose)

@daviseford daviseford added the rule updates Fixing incorrect or outdated rules label Jan 24, 2023
@daviseford daviseford self-requested a review January 24, 2023 02:33
Copy link
Owner

@daviseford daviseford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! I ran yarn prepushto format the code, otherwise the automated tests would fail. Other than that, perfect! Thank you so much.

@daviseford daviseford merged commit 795c546 into daviseford:master Jan 24, 2023
@davefatkin davefatkin deleted the battle-tactics-when-fixes branch January 24, 2023 03:11
@davefatkin
Copy link
Contributor Author

looks great! I ran yarn prepushto format the code, otherwise the automated tests would fail. Other than that, perfect! Thank you so much.

Got it! Will remember next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule updates Fixing incorrect or outdated rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants