-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making Battle Tactics when
values uniform across factions
#1587
Making Battle Tactics when
values uniform across factions
#1587
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! I ran yarn prepush
to format the code, otherwise the automated tests would fail. Other than that, perfect! Thank you so much.
Got it! Will remember next time. |
I noticed when creating a Sylvaneth army with the app that if I included the Gallet Realm of Battle that the Battle Tactics for the GHB and Sylvaneth were in two different sections. 'Start Of Hero Phase` and 'Start Of Round', respectively.
I updated a couple of factions to use
START_OF_HERO_PHASE
rather thanSTART_OF_ROUND
to keep things in line with the existing pattern.A few other things I changed to try and match existing patterns:
Battle Tactic:
from thename
fields (I left them intact inrealmscapes.ts
)