Update welcome email

Author: davidmerfield

Diff for: app/dashboard/sign-up/index.js

@@ -214,6 +214,8 @@ passwordForm.post(parse, csrf, function (req, res, next) {
           sameSite: "Lax"
         });
 
+        Email.WELCOME(user.uid);
+
         req.session.uid = user.uid;        
         res.redirect("/sites/account/create-site");
       }

Diff for: app/scheduler/index.js

@@ -11,10 +11,8 @@ const freeDiskSpace = require("./free-disk-space");
 const os = require("os");
 const fs = require("fs-extra");
 const exec = require("child_process").exec;
-const fix = require("sync/fix/all");
 const zombies = require("./zombies");
 const checkCardTesters = require("./check-card-testers");
-const welcomeEmail = require("./welcome-email");
 
 // If any disk has less than 2GB of space, we should notify the admin
 const MINIMUM_DISK_SPACE_IN_K = 2 * 1024 * 1024;
@@ -119,9 +117,6 @@ module.exports = function () {
     console.log(clfdate(), "Scheduled entries for future publication");
   });
 
-  // Schedule welcome emails for new users
-  welcomeEmail();
-  
   // Warn users about impending subscriptions
   User.getAllIds(function (err, uids) {
     async.each(uids, User.scheduleSubscriptionEmail, function (err) {

Diff for: app/scheduler/welcome-email.js

@@ -104,9 +104,8 @@ function main(callback) {
 
         // Run any initialization that clients need
         // Google Drive will renew any webhooks, e.g.
-        for (const { init, display_name } of Object.values(
-          require("clients")
-        )) {
+        const clients = Object.values(require("clients"));
+        for (const { init, display_name } of clients) {
           if (init) {
             console.log(clfdate(), display_name + " client:", "Initializing");
             init();
@@ -118,13 +117,14 @@ function main(callback) {
       function (callback) {
         // Flush the cache of the public site and documentation
         flush();
-
         callback();
       },
 
       function (callback) {
         if (config.environment !== "development") return callback();
+
         configureLocalBlogs();
+        callback();
       },
     ],
     callback

Diff for: app/setup.js

@@ -49,26 +49,18 @@ Speed up templates.build
 
 Create a folder{watch} equivalent so we don't have to run a seperate process for development
 
-Run documentation build on github actions
-
 Worried about depending on Bunny – can we work out a plan to move away from them if needed?
 
-Work out why the mac server is restarting and resolve the issue
-- every time it restarts, add the debug command to the email notification
-
 Containerize the proxy (openresty/nginx)
 - add varnish afterwards to handle the load balancing and caching
 - get rid of openrestycache
 
-Work out why the main server is restarting and resolve the issue
-- every time it restarts
-
 Fix image profile retention not working in production and tell [Simon](https://mail.google.com/mail/u/0/#inbox/FMfcgzGwJchvfhDcWNkrZtNJqlLmLfsx)
 - maybe a caching issue and actually works?
 
 Improve production image build time for fast bug fixes and deploys
 - When should folder zipping happen?
-- Can we move documentation building and folder zipping into dockerfile? improve build speed by removing github actions cache?
+- Can we improve build speed by removing github actions cache and using some base image with dependencies?
 
 Use tinify free api to compress some of the folder images
 - maybe consider building this into the main product? it might pay for itself
@@ -78,8 +70,6 @@ Fix bug with first edit on forked template on template editor:
 - 2. change the text color
 - 3. nothing happens (due to the inital fork) until you reload the page
 
-Move welcome email to send after user creation
-
 Add asset library / file upload to template editor and share files across templates
 - use this to help implement a favicon feature which minifies the favicon