Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cargo binstall? #223

Open
marxin opened this issue Dec 6, 2024 · 9 comments
Open

Add support for cargo binstall? #223

marxin opened this issue Dec 6, 2024 · 9 comments

Comments

@marxin
Copy link
Collaborator

marxin commented Dec 6, 2024

Cargo Binary Install is pretty popular mechanism when it comes to installation of Rust binary tools. Apparently, it's something that communicates with crates.io, but I haven't read the documentation yet.

Once we've included cargo-dist, I thought it would be worth supporting as well. What others think about it?

@mati865
Copy link
Contributor

mati865 commented Dec 11, 2024

Wild would have to be published on crates.io first.

@marxin
Copy link
Collaborator Author

marxin commented Dec 13, 2024

@davidlattimore Can you consider publishing the crate to crates.io?

@davidlattimore
Copy link
Owner

Sure, I guess we can do that. First, we'll need to settle on some package names. For the linker itself, wild-linker would be an obvious choice. I'm wondering if we should rename wild_lib to wild-lib, unless someone else has any better names.

Then there's linker-diff, linker-layout, linker-trace and linker-utils. I guess they're OK, but also open to other suggestions.

@marxin
Copy link
Collaborator Author

marxin commented Dec 14, 2024

Sure, I guess we can do that. First, we'll need to settle on some package names. For the linker itself, wild-linker would be an obvious choice. I'm wondering if we should rename wild_lib to wild-lib, unless someone else has any better names.

I support that and it seems natural to me to have the same name conventions (by using a dash instead of an underscore).

About the other tools: are you planning to make them available as crates on crates.io?

@davidlattimore
Copy link
Owner

By tools, you mean linker-diff? It's a dev-dependency of wild. I'm not 100% sure, but I think crates.io won't let you publish a crate if its dev dependencies aren't published.

@davidlattimore
Copy link
Owner

Or do you do mean the non-binary crates like linker-layout? Those we'd definitely have to publish, since they're not even dev-dependencies. Open to rename suggestions though if we think the current names are too generic.

@marxin
Copy link
Collaborator Author

marxin commented Dec 14, 2024

Ah, ok, makes sense one needs to publish all dependencies, otherwise one can't build it properly :)
I'm fine with the currently used names.

@heavyrain266
Copy link

heavyrain266 commented Dec 14, 2024

I'm wondering if we should rename wild_lib to wild-lib, unless someone else has any better names.

I suggest libwild, Pijul went with libpijul, and I plan to release libjinx. Users can do global alias using:

pub(crate) use libwild as wild

@davidlattimore
Copy link
Owner

I suggest libwild, Pijul went with libpijul, and I plan to release libjinx.

That seems reasonable to me. I'll probably go with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants