Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addEventListener() and removeEventListener() methods #710

Open
gruns opened this issue May 20, 2019 · 5 comments
Open

Add addEventListener() and removeEventListener() methods #710

gruns opened this issue May 20, 2019 · 5 comments

Comments

@gruns
Copy link

gruns commented May 20, 2019

Currently event handlers can only be setup at initialization time in the
constructor's options parameter.

Instead, iFrameResizer should implement the standard EventTarget interface

with addEventListener(), removeEventListener(), and dispatchEvent() so 1)
iFrameResizer follows the standard JS events API and 2) event handling can
change dynamically.

@davidjbradshaw
Copy link
Owner

Do you want to make a PR?

@gruns
Copy link
Author

gruns commented Jun 28, 2019

Do you want to make a PR?

I'd love to, but I am starved for time right now. I won't be able to take a stab
at this for, at minimum, a few weeks.

To anyone with providential inclination: feel free to take a crack at this.

@davidjbradshaw
Copy link
Owner

davidjbradshaw commented Jul 2, 2019 via email

@davidjbradshaw
Copy link
Owner

Roadmapped for v5.1

@bertho-zero
Copy link

That would be nice, we can't add onMessage after initialization at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants