Merge pull request #5 from davidfrp/feature/SAGA-12-implement-issue-view-command

fix: invalid issue url

Author: davidfrp

src/commands/ready.ts

@@ -39,14 +39,18 @@ export default class Ready extends AuthCommand {
       this.initGitService(),
     ]);
 
+    const shouldUndo = flags.undo;
+
+    if (!shouldUndo) {
+      this.log(chalk.dim("(Use --undo flag to undo this action)"));
+    }
+
     const projectKey = await this.resolveProjectKey(jira);
 
     await this.handlePullRequestExistance(git);
 
     const issue = await this.resolveIssue(jira, git, projectKey);
 
-    const shouldUndo = flags.undo;
-
     const transition = issue
       ? await this.resolveIssueTransition(jira, shouldUndo, issue)
       : undefined;
@@ -61,15 +65,6 @@ export default class Ready extends AuthCommand {
 
     await this.handleWhatsNext(jira, git, issue);
 
-    if (!shouldUndo) {
-      this.log();
-      this.log(
-        chalk.dim(
-          "Hint: You can use the --undo flag with the ready command to undo this action."
-        )
-      );
-    }
-
     this.log();
   }
 
@@ -110,8 +105,6 @@ export default class Ready extends AuthCommand {
         this.open(issueUrl);
         break;
     }
-
-    this.log();
   }
 
   private getSequencer(
@@ -284,15 +277,21 @@ export default class Ready extends AuthCommand {
         ) ?? null;
     }
 
-    if (!transition) {
+    if (!transitionStatus) {
+      this.log(chalk.yellow("!"), "No issue status found.");
+    }
+
+    if (transitionStatus && !transition) {
       this.log(
         chalk.yellow("!"),
         format(
-          "The issue status %s is no longer available for this issue.",
+          "The issue status %s is no longer available.",
           chalk.cyan(transitionStatus)
         )
       );
+    }
 
+    if (!transition) {
       transition = await chooseTransition(filteredTransitions);
 
       if (!transition.name) {

src/services/jira/JiraService.ts

@@ -121,7 +121,7 @@ export class JiraService {
   }
 
   public constructIssueUrl(issue: Issue) {
-    return `https://${this.host}/browse/${issue.key}`;
+    return `${this.host}/browse/${issue.key}`;
   }
 
   public extractIssueKey(projectKey: string, value: string) {