Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disposable issues #150

Open
adamradocz opened this issue May 7, 2022 · 0 comments
Open

Disposable issues #150

adamradocz opened this issue May 7, 2022 · 0 comments

Comments

@adamradocz
Copy link
Contributor

Noticed a few potential issues:

  • ConnectionLimitMiddleware doesn't call Dispose on SemaphoreSlim _limiter.
  • ConsumableArrayBufferWriter should be sealed or the Dispose should be virtual.
  • TimerAwaitable should be sealed or the Dispose should be virtual.
  • ConnectionContextWithDelegate is disposing the ConnectionContext connection, although it is injected.
  • SocketSender doesn't call Dispose on SocketAsyncEventArgs _eventArgs. Plus, the _eventArgs.Completed += (_, e) => ((SocketAwaitable)e.UserToken).Complete(e.BytesTransferred, e.SocketError); not a memory leak, as it never unsubscribed? This is the same with the SocketReceiver.
  • ServerConnection doesn't call Dispose on CancellationTokenSource _connectionClosingCts.
  • Server doesn't call Dispose on TimerAwaitable _timerAwaitable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant