Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry functionality does not respect context cancellation #3

Closed
davesavic opened this issue Jan 7, 2024 · 0 comments · Fixed by #4
Closed

Retry functionality does not respect context cancellation #3

davesavic opened this issue Jan 7, 2024 · 0 comments · Fixed by #4
Assignees
@davesavic
Labels
bug Something isn't working

Comments

@davesavic
Copy link
Owner

The current functionality surrounding retries will not be cancelled if the request context is cancelled. The sleeping between retries is also currently unaware of a context cancellation.

PR Inbound.
@davesavic davesavic added the bug Something isn't working label Jan 7, 2024
@davesavic davesavic self-assigned this Jan 7, 2024
@davesavic davesavic linked a pull request Jan 7, 2024 that will close this issue
Updated functionality to support context cancellation + tests #4
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davesavic davesavic

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated functionality to support context cancellation + tests davesavic/clink
1 participant
@davesavic