Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with basePath set to root or empty #423

Open
andre-l-mm opened this issue Jan 14, 2022 · 1 comment
Open

Issue with basePath set to root or empty #423

andre-l-mm opened this issue Jan 14, 2022 · 1 comment
Labels
good first issue Good for newcomers looking into it

Comments

@andre-l-mm
Copy link

Hosting an api with basePath in swagger document not set or set to just a single slash ("/") does not seem to work.

With basePath set to "/", this library only listens to requests on a double slash ("//"). It seems it concatenates the basePath slash to the initial slash in resource paths. Requests with a single slash fail and return 404.

With basePath empty, I am not sure what routing pattern is being produced as I only get 404 responses.

Swagger ui in both cases ignores the basePath which seems a more reasonable behaviour.
@davesag
Copy link
Owner

davesag commented Jul 30, 2022

Hi @andre-l-mm sorry for taking such a long time to get back to you. I'll take a look at this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers looking into it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davesag @andre-l-mm