Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Vitest workspace #377

Merged
merged 8 commits into from
Jun 25, 2024

Conversation

xeho91
Copy link
Contributor

@xeho91 xeho91 commented Jun 20, 2024

Resolves #376

Copy link
Owner

@davelosert davelosert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xeho91: Thank you very much for this PR. I left one comment about the main bit, where I believe the wrong strings / paths are placed?

Also, could you update the options section of the readme.md with these change?

And I would love to have another section in the Coverage-Thresholds Section of the Documentation with this warning:

Warning

Currently, this action does not import the vite-configuration, but parses it as string to extract the coverage-thresholds by an regexp. In other words: All thresholds need to be directly defined in the config-file given to this action through the vite-config-path input. E.g., when using workspace to extend a parent-configuration, the thresholds can not be defined in the parent-config.

src/inputs/getViteConfigPath.ts Outdated Show resolved Hide resolved
@xeho91 xeho91 requested a review from davelosert June 25, 2024 07:29
@xeho91
Copy link
Contributor Author

xeho91 commented Jun 25, 2024

Also, could you update the options section of the readme.md with these change?

I was lost for a moment, so I have to ask. Did I guess correctly - you meant the Default column?

And I would love to have another section in the Coverage-Thresholds Section of the Documentation with this warning:

Warning

Currently, this action does not import the vite-configuration, but parses it as string to extract the coverage-thresholds by an regexp. In other words: All thresholds need to be directly defined in the config-file given to this action through the vite-config-path input. E.g., when using workspace to extend a parent-configuration, the thresholds can not be defined in the parent-config.

No problem, I added at the top of aforementioned section. Is this where you wanted this warning to display?

README.md Outdated Show resolved Hide resolved
@davelosert
Copy link
Owner

@xeho91 : Yep, perfect, thank you!
There was a list minor formatting issue, but I just went ahead and fixed that myself to not trouble you any further.

As soon as the code-scan is succesfull, I will merge and release this.

Thank you very much for this contribution! ❤️

@davelosert davelosert merged commit 0b20990 into davelosert:main Jun 25, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 25, 2024
# [2.5.0](v2.4.0...v2.5.0) (2024-06-25)

### Bug Fixes

* **deps:** bump braces from 3.0.2 to 3.0.3 ([#374](#374)) ([1ae9c3f](1ae9c3f))

### Features

* Add support for Vitest workspace ([#377](#377)) ([0b20990](0b20990)), closes [#376](#376)
@xeho91 xeho91 deleted the support-vitest-workspace branch June 25, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Vitest workspace feature
2 participants