Skip to content

Naming #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lawkss opened this issue May 20, 2024 · 2 comments · Fixed by #6
Closed

Naming #5

Lawkss opened this issue May 20, 2024 · 2 comments · Fixed by #6
Assignees
Labels
improvement Minor improvement to functionality

Comments

@Lawkss
Copy link

Lawkss commented May 20, 2024

Thanks for the module!

I have some suggestions:

Change the module name to include capital letters? all other webmin modules have the second word as capital.

So

Docker container management

to

Docker Container Management

or I would prefer just:

Docker Containers

it would also be cool to get the icon checks for the status like for server dashboard:

Screenshot 2024-05-20 174417

@dave-lang dave-lang linked a pull request May 23, 2024 that will close this issue
@dave-lang dave-lang reopened this May 23, 2024
@dave-lang
Copy link
Owner

Good suggestions

I've just made the naming change and there's a minor release up. I'll look at doing the icons in the next day or two

@dave-lang dave-lang self-assigned this May 23, 2024
@dave-lang dave-lang added good first issue Good for newcomers improvement Minor improvement to functionality labels May 23, 2024
@dave-lang
Copy link
Owner

Added a simple icon for the running status, leaving the actual actions as strings for now as it's clearer what they do

@dave-lang dave-lang removed the good first issue Good for newcomers label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Minor improvement to functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants