fix(agent): change anthropic client to pointer type

Changed the anthropic client from a value type to a pointer type to better handle client initialization. This change allows for lazy initialization of the client when needed during Run() if not already provided.

Added a check to initialize the client at runtime if not already set, which helps prevent nil pointer dereference errors when the agent is created without an API key initially.

Author: tdabasinskas

internal/agent/agent.go

@@ -38,7 +38,7 @@ type Status string
 
 // Agent is a struct that contains the state of the agent.
 type Agent struct {
-	client        anthropic.Client
+	client        *anthropic.Client
 	ctx           context.Context
 	cfg           config.Configuration
 	logger        *slog.Logger
@@ -88,7 +88,8 @@ func New(opts ...Option) *Agent {
 	}
 
 	if a.cfg.Anthropic.APIKey != "" {
-		a.client = anthropic.NewClient(option.WithAPIKey(a.cfg.Anthropic.APIKey))
+		c := anthropic.NewClient(option.WithAPIKey(a.cfg.Anthropic.APIKey))
+		a.client = &c
 	}
 
 	a.logger.WithGroup("config").With("max_tokens", a.cfg.Anthropic.MaxTokens).With("model", a.cfg.Anthropic.Model).
@@ -119,7 +120,7 @@ func WithLogger(logger *slog.Logger) Option {
 }
 
 // WithClient sets the client for the agent.
-func WithClient(client anthropic.Client) Option {
+func WithClient(client *anthropic.Client) Option {
 	return func(a *Agent) {
 		a.client = client
 	}
@@ -146,6 +147,15 @@ func (a *Agent) Run(opts *tool.RunOptions, ctx context.Context) ([]tool.Output,
 		ctx = a.ctx
 	}
 
+	// Initialize client if not already initialized
+	if a.client == nil {
+		if a.cfg.Anthropic.APIKey == "" {
+			return nil, fmt.Errorf("anthropic API key is required but not provided")
+		}
+		c := anthropic.NewClient(option.WithAPIKey(a.cfg.Anthropic.APIKey))
+		a.client = &c
+	}
+
 	prompt, err := assets.RenderAgentSystemPrompt(&assets.AgentSystemPromptData{
 		Shell: a.cfg.Tools.Exec.Shell,
 	})
@@ -178,7 +188,6 @@ func (a *Agent) Run(opts *tool.RunOptions, ctx context.Context) ([]tool.Output,
 			msg.ToolChoice = anthropic.ToolChoiceUnionParam{
 				OfToolChoiceAuto: &anthropic.ToolChoiceAutoParam{
 					DisableParallelToolUse: param.NewOpt(true),
-					Type:                   msg.ToolChoice.OfToolChoiceAuto.Type,
 				},
 			}
 		}

internal/agent/agent_test.go

@@ -42,7 +42,7 @@ func TestNew(t *testing.T) {
 		assert.NotNil(t, agent.cfg)
 		assert.NotNil(t, agent.logger)
 		assert.NotNil(t, agent.communication)
-		assert.Equal(t, anthropic.Client{}, agent.client) // Check for zero value instead of nil
+		assert.Nil(t, agent.client) // Default agent should have nil client
 	})
 
 	t.Run("applies options", func(t *testing.T) {
@@ -65,13 +65,16 @@ func TestNew(t *testing.T) {
 		assert.Equal(t, ctx, agent.ctx)
 		assert.Equal(t, cfg, agent.cfg)
 		assert.Equal(t, comm, agent.communication)
+		assert.Nil(t, agent.client) // Agent without API key should have nil client
 	})
 
 	t.Run("creates client when API key provided", func(t *testing.T) {
 		cfg := config.New().GetConfig()
 		cfg.Anthropic.APIKey = "test-key"
 		agent := New(WithConfig(cfg))
 		assert.NotNil(t, agent.client)
+		// Verify client is properly initialized by checking its type
+		assert.IsType(t, &anthropic.Client{}, agent.client)
 	})
 }