Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The update to end all updates #5214

Merged
merged 6 commits into from
Mar 17, 2019
Merged

The update to end all updates #5214

merged 6 commits into from
Mar 17, 2019

Conversation

FriedrichWeinmann
Copy link
Member

Type of Change

  • Bug fix (non-breaking change, fixes #)
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

High Level Changes

  • Fixed TEPP
  • Fixed Get-DbaCmObject erroneously assuming computer unreachable
  • Upgraded Select-DbaObject
  • Fixed error when failing config validation
  • Fixed DbaInstanceParameter input interpretation

Bloody Details

Fixed TEPP

Was removed from import sequence and several module changes had not been reflected into its settings (notably: Path related content).

  • Added back to import sequence
  • Fixed broken paths
  • Restored Async calculation
  • Error Handling for unknown type in parameters
  • Restored data refresh signal when connecting repeatedly

Resolves #5171

Fixed Get-DbaCmObject erroneously assuming computer unreachable

Not all CIM errors relating to service and classes had been caught. This caused the default error (Server unreachable) to kick in. Availability caching meant subsequent calls would instantly fail, even when legit.

  • Implemented every single CIM status code

Resolves: #4096

Upgraded Select-DbaObject

Added further functionality to the command to fully emulate Select-PSFObject. This gives it the ability to add aliases, script properties and script methods, all in one call.
With this, it can implement the full functionality of Select-DefaultView (but it cannot be bulk replaced) for better overall performance.

Fixed error when failing config validation

For some technical reasons, the error messages was was written from without the module.
Thus on error it would try to run Stop-Function, which is only available internally, giving the wrong error message.

  • Fixed by invoking from within the module

Resolves #5065

Note: Also added shorthand values for size types for the setting shown in the issue.

Fixed DbaInstanceParameter input interpretation

After the recent change, to better support azure connections, it used to discard instance information from repeatedly used SMO server objects.

  • Added DbaInstanceName to the SMO object generated by Connect-DbaInstance
  • Added IsAzure to the SMO object generated by Connect-DbaInstance
  • Added fallback to old mode when handling SMO server objects not generated by dbatools

Note: The tab indent tests will cry havoc. That's cool with me.

@potatoqualitee
Copy link
Member

approved! tyvm. failures in second run are cuz of appveyor

@potatoqualitee potatoqualitee merged commit 17a088d into development Mar 17, 2019
@potatoqualitee potatoqualitee deleted the CM branch March 17, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants