Add new login support for Azure SQL Dbs

[cdhunt]

Type of Change

• Bug fix (non-breaking change, fixes New-DbaLogin does not work on Azure SQL "Keyword or statement option 'hashed' is not supported" #5100
• New feature (non-breaking change, adds functionality)
• Breaking change (effects multiple commands or functionality)
• Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
• Adding code coverage to existing functionality
• Pester test is included
• If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
• Nunit test is included
• Documentation
• Build system

Purpose

Add Azure SQL Db support.

Approach

An extra conditional branched based on $server.DatabaseEngineType.

Commands to test

New-DbaLogin -Login $UserName -SecurePassword $Password

Screenshots

Learning

[potatoqualitee]

awwww yeahh! thank you, fabulous addition. will merge when tests pass 💯

[potatoqualitee]

Tests pass! Gonna merge, do a few other PRs and publish to gallery. Thanks so much!

[wsmelton]

@potatoqualitee This needs to include a validation that if a login name is passed with @ to throw a warning that it does not support creating Azure Logins for Azure AD accounts. It will be a bit misleading if we say the command supports creating "Azure SQL Logins", it will be strictly SQL Logins.

[cdhunt]

@wsmelton Can you provide some more context? I don't use Azure Logins. If you want to open a new issue, I can try and put in the extra validation.

[wsmelton]

You cannot create an Azure SQL Login for an Azure AD account using "CREATE LOGIN [$loginName] FROM WINDOWS" + $withParams it will fail.

If we want to support both there has to be a same check for the type of database engine and then using the T-SQL "CREATE LOGIN [$loginName] FROM EXTERNAL PROVIDER" , that is all you can do for Azure AD accounts....there are no additional parameters and such. Logins in Azure SQL do not grant access to the databases, you have to explicitly create those after you create the login because there is no sysadmin role and such.

[cdhunt]

@wsmelton Would you suggest creating another condition at New-DbaLogin.ps1#L273 to add a AzureADLogin for $loginType?