Fix masking commands

allcommands.ps1

@@ -12958,6 +12958,7 @@ function Copy-DbaSsisCatalog {
     )
     <# Developer note: The throw calls must stay in this command #>
     begin {
+        $ISNamespace = "Microsoft.SqlServer.Management.IntegrationServices"
         function Get-RemoteIntegrationService {
             param (
                 [Object]$Computer
@@ -55110,13 +55111,13 @@ function Install-DbaMaintenanceSolution {
         Installs Ola Hallengren's Solution objects on RES14224 in the DBA database.
         Backups will default to the default Backup Directory.
         If the Maintenance Solution already exists, the script will be halted.
-    
+
     .EXAMPLE
         PS C:\> Install-DbaMaintenanceSolution -SqlInstance RES14224 -Database DBA -BackupLocation "Z:\SQLBackup" -CleanupTime 72
 
         This will create the Ola Hallengren's Solution objects. Existing objects are not affected in any way.
 
-    
+
     .EXAMPLE
         PS C:\> $params = @{
                 >> SqlInstance = 'MyServer'
@@ -55129,7 +55130,7 @@ function Install-DbaMaintenanceSolution {
                 >> Verbose = $true
                 >> }
                 >> Install-DbaMaintenanceSolution @params
-    
+
         Installs Maintenance Solution to myserver in database. Adds Agent Jobs, and if any currently exist, they'll be replaced.
 
     .EXAMPLE
@@ -55400,7 +55401,7 @@ function Install-DbaMaintenanceSolution {
                     if ($jobs) {
                         $jobs | ForEach-Object {
                             if ($Pscmdlet.ShouldProcess($instance, "Dropping job $_.name")) {
-                                Remove-DbaAgentJob -SqlInstance $instance -Job $_.name
+                                Remove-DbaAgentJob -SqlInstance $server -Job $_.name
                             }
                         }
                     }
@@ -85458,12 +85459,12 @@ function Set-DbaAgentSchedule {
 
                         if ($StartDate) {
                             Write-Message -Message "Setting job schedule start date to $StartDate for schedule $ScheduleName" -Level Verbose
-                            $JobSchedule.StartDate = $StartDate
+                            $JobSchedule.ActiveStartDate = $StartDate
                         }
 
                         if ($EndDate) {
                             Write-Message -Message "Setting job schedule end date to $EndDate for schedule $ScheduleName" -Level Verbose
-                            $JobSchedule.EndDate = $EndDate
+                            $JobSchedule.ActiveEndDate = $EndDate
                         }
 
                         if ($StartTime) {

appveyor.yml

@@ -24,7 +24,7 @@ shallow_clone: true
 environment:
   environment: development
   version: 0.9.$(appveyor_build_number)
-  #appveyor_rdp_password: 2odCuiKmYiem
+  appveyor_rdp_password: 2odCuiKmYiem
   azurepasswd:
     secure: ZnF3fWSDfHraMCWlHaekvWrXf3sDqY5M28HMK4236PBbNSoqP29wEhsWMQioSSYGomzgIp9vuiwR8Fc9ViNLoqq0bVcErxEojBFTaPMEzOg2ZwO9OnOTiuUEc5JkoLBv6rEBBWef/DvkFfhr1r0K0xQu6OAPYHVTCRajTZbBRNfCTUM2X2o41t+cSa7681rtnJQnB/8cAfVVnPtJ+97s8w==
   azurelegacypasswd:

bin/datamasking/columntypes.json

@@ -1,49 +1,54 @@
 [
     {
-        "TypeName": "Firstname",
+        "TypeName": "Address",
         "Synonym": [
-            "Firstname",
-            "Forename"
+            "Address",
+            "Location",
+            "Headquarters",
+            "Street"
         ]
     },
     {
-        "TypeName": "Lastname",
+        "TypeName": "Bic",
         "Synonym": [
-            "Lastname",
-            "Surname"
+            "Bic",
+            "BicAddress"
         ]
     },
     {
-        "TypeName": "Fullname",
+        "TypeName": "Bitcoin",
         "Synonym": [
-            "Fullname",
-            "TypeName"
+            "Bitcoin",
+            "BitcoinAddress"
         ]
     },
     {
-        "TypeName": "Phone",
+        "TypeName": "Email",
         "Synonym": [
-            "Phonenumber",
-            "Phone",
-            "Telephone",
-            "TelephoneNumber"
+            "Email",
+            "E-mail",
+            "EmailAddress"
         ]
     },
     {
-        "TypeName": "Address",
+        "TypeName": "Ethereum",
         "Synonym": [
-            "Address",
-            "Location",
-            "Headquarters",
-            "Street"
+            "Ethereum",
+            "EthereumAddress"
         ]
     },
     {
-        "TypeName": "Zipcode",
+        "TypeName": "Creditcard",
         "Synonym": [
-            "Zipcode",
-            "Zip",
-            "Postalcode"
+            "Creditcard",
+            "CreditcardNumber"
+        ]
+    },
+    {
+        "TypeName": "CreditcardCVV",
+        "Synonym": [
+            "Cvv",
+            "CreditcardCvv"
         ]
     },
     {
@@ -53,9 +58,10 @@
         ]
     },
     {
-        "TypeName": "State",
+        "TypeName": "Company",
         "Synonym": [
-            "State"
+            "Company",
+            "CompanyName"
         ]
     },
     {
@@ -70,6 +76,34 @@
             "CountryCode"
         ]
     },
+    {
+        "TypeName": "Firstname",
+        "Synonym": [
+            "Firstname",
+            "Forename"
+        ]
+    },
+    {
+        "TypeName": "Fullname",
+        "Synonym": [
+            "Fullname",
+            "TypeName"
+        ]
+    },
+    {
+        "TypeName": "Iban",
+        "Synonym": [
+            "Iban",
+            "IbanNumber"
+        ]
+    },
+    {
+        "TypeName": "Lastname",
+        "Synonym": [
+            "Lastname",
+            "Surname"
+        ]
+    },
     {
         "TypeName": "Latitude",
         "Synonym": [
@@ -85,19 +119,44 @@
         ]
     },
     {
-        "TypeName": "Creditcard",
+        "TypeName": "Phone",
         "Synonym": [
-            "Creditcard",
-            "CreditcardNumber"
+            "Fax",
+            "FaxNumber",
+            "Phonenumber",
+            "Phone",
+            "Telephone",
+            "TelephoneNumber"
+        ]
+    },
+    {
+        "TypeName": "State",
+        "Synonym": [
+            "State"
+        ]
+    },
+    {
+        "TypeName": "StateAbbr",
+        "Synonym": [
+            "StateAbbreviation",
+            "StateCode"
         ]
     },
     {
         "TypeName": "Username",
         "Synonym": [
             "Login",
-			"LoginId",
+            "LoginId",
             "User",
             "UserId"
         ]
+    },
+    {
+        "TypeName": "Zipcode",
+        "Synonym": [
+            "Zipcode",
+            "Zip",
+            "Postalcode"
+        ]
     }
 ]

changelog.md

@@ -5,6 +5,16 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
     and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.9.773] - 2019-02-24
+### Fixed
+* `Install-DbaMaintenanceSolution` now removes jobs when `-SqlCredential` is used [#5096](https://github.com/sqlcollaborative/dbatools/issues/5096)
+* `Copy-DbaSsisCatalog` now properly resolves type names [#4821](https://github.com/sqlcollaborative/dbatools/issues/4821)
+* Can now set schedule start & end dates with `Set-DbaAgentSchedule` [#4908](https://github.com/sqlcollaborative/dbatools/issues/4908)
+
+## [0.9.772] - 2019-02-24
+### Fixed
+* `Invoke-DbaDbShrink` now properly excludes system databases when `-AllUserDatabase` is specified [#5108](https://github.com/sqlcollaborative/dbatools/issues/5108)
+
 ## [0.9.771] - 2019-02-19
 ### Fixed
 * Azure SQL DB support for creating SQL Logins in `New-DbaLogin` [#5100](https://github.com/sqlcollaborative/dbatools/issues/5100)

dbatools.psd1

@@ -11,7 +11,7 @@
     RootModule             = 'dbatools.psm1'
 
     # Version number of this module.
-    ModuleVersion          = '0.9.772'
+    ModuleVersion          = '0.9.773'
 
     # ID used to uniquely identify this module
     GUID                   = '9d139310-ce45-41ce-8e8b-d76335aa1789'

functions/Backup-DbaDatabase.ps1

@@ -213,18 +213,19 @@ function Backup-DbaDatabase {
             Write-Message -Message 'Setting Default timestampformat' -Level Verbose
             $TimeStampFormat = "yyyyMMddHHmm"
         }
-        if ($SqlInstance.length -ne 0) {
+
+        if ($SqlInstance) {
             try {
                 $Server = Connect-SqlInstance -SqlInstance $SqlInstance -SqlCredential $SqlCredential -AzureUnsupported
             } catch {
                 Stop-Function -Message "Cannot connect to $SqlInstance" -ErrorRecord $_
                 return
             }
 
+            $InputObject = $server.Databases | Where-Object Name -ne 'tempdb'
+
             if ($Database) {
-                $InputObject = $server.Databases | Where-Object Name -in $Database
-            } else {
-                $InputObject = $server.Databases | Where-Object Name -ne 'tempdb'
+                $InputObject = $InputObject | Where-Object Name -in $Database
             }
 
             if ($ExcludeDatabase) {
@@ -280,13 +281,21 @@ function Backup-DbaDatabase {
     }
 
     process {
-        if (!$SqlInstance -and !$InputObject) {
+        if (-not $SqlInstance -and -not $InputObject) {
             Stop-Function -Message "You must specify a server and database or pipe some databases"
             return
         }
 
         Write-Message -Level Verbose -Message "$($InputObject.Count) database to backup"
 
+        if ($Database) {
+            $InputObject = $InputObject | Where-Object Name -in $Database
+        }
+
+        if ($ExcludeDatabase) {
+            $InputObject = $InputObject | Where-Object Name -notin $ExcludeDatabase
+        }
+
         foreach ($db in $InputObject) {
             $ProgressId = Get-Random
             $failures = @()